352-v5.4-0007-brcmfmac-remove-unnecessary-strlcpy-upon-obtaining-v.patch 1.2 KB

12345678910111213141516171819202122232425262728
  1. From 4b11c915f00caeef3292ed0429acc579b9da762a Mon Sep 17 00:00:00 2001
  2. From: Arend van Spriel <arend.vanspriel@broadcom.com>
  3. Date: Thu, 11 Jul 2019 11:05:12 +0200
  4. Subject: [PATCH] brcmfmac: remove unnecessary strlcpy() upon obtaining "ver"
  5. iovar
  6. Recently a strcpy() was replaced by strlcpy(). However, the strcpy()
  7. was not needed in the first place. So removing that line of code.
  8. Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
  9. Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
  10. Reviewed-by: Franky Lin <franky.lin@broadcom.com>
  11. Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
  12. Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  13. ---
  14. drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 1 -
  15. 1 file changed, 1 deletion(-)
  16. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
  17. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
  18. @@ -157,7 +157,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
  19. /* query for 'ver' to get version info from firmware */
  20. memset(buf, 0, sizeof(buf));
  21. - strlcpy(buf, "ver", sizeof(buf));
  22. err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
  23. if (err < 0) {
  24. bphy_err(drvr, "Retrieving version information failed, %d\n",