0586-drm-vc4-Fulfill-user-BO-creation-requests-from-the-k.patch 1.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354
  1. From 6b7250b2393653e5d08deed591b78b41a2ee8d43 Mon Sep 17 00:00:00 2001
  2. From: Eric Anholt <eric@anholt.net>
  3. Date: Wed, 8 Feb 2017 15:00:54 -0800
  4. Subject: [PATCH] drm/vc4: Fulfill user BO creation requests from the kernel BO
  5. cache.
  6. The from_cache flag was actually "the BO is invisible to userspace",
  7. so we can repurpose to just zero out a cached BO and return it to
  8. userspace.
  9. Improves wall time for a loop of 5 glsl-algebraic-add-add-1 by
  10. -1.44989% +/- 0.862891% (n=28, 1 outlier removed from each that
  11. appeared to be other system noise)
  12. Note that there's an intel-gpu-tools test to check for the proper
  13. zeroing behavior here, which we continue to pass.
  14. Signed-off-by: Eric Anholt <eric@anholt.net>
  15. ---
  16. drivers/gpu/drm/vc4/vc4_bo.c | 13 +++++++------
  17. 1 file changed, 7 insertions(+), 6 deletions(-)
  18. --- a/drivers/gpu/drm/vc4/vc4_bo.c
  19. +++ b/drivers/gpu/drm/vc4/vc4_bo.c
  20. @@ -208,22 +208,23 @@ struct drm_gem_object *vc4_create_object
  21. }
  22. struct vc4_bo *vc4_bo_create(struct drm_device *dev, size_t unaligned_size,
  23. - bool from_cache)
  24. + bool allow_unzeroed)
  25. {
  26. size_t size = roundup(unaligned_size, PAGE_SIZE);
  27. struct vc4_dev *vc4 = to_vc4_dev(dev);
  28. struct drm_gem_cma_object *cma_obj;
  29. int pass, ret;
  30. + struct vc4_bo *bo;
  31. if (size == 0)
  32. return ERR_PTR(-EINVAL);
  33. /* First, try to get a vc4_bo from the kernel BO cache. */
  34. - if (from_cache) {
  35. - struct vc4_bo *bo = vc4_bo_get_from_cache(dev, size);
  36. -
  37. - if (bo)
  38. - return bo;
  39. + bo = vc4_bo_get_from_cache(dev, size);
  40. + if (bo) {
  41. + if (!allow_unzeroed)
  42. + memset(bo->base.vaddr, 0, bo->base.base.size);
  43. + return bo;
  44. }
  45. /* Otherwise, make a new BO. */