Home Explore Help
Register Sign In
wareck
/
openwrt-archive
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: 2f76d8f3a7
Branches Tags
openwrt-archive
/
package
/
kernel
/
mac80211
/
patches
/
351-0011-brcmfmac-don-t-remove-interface-on-link-down-firmwar.patch

351-0011-brcmfmac-don-t-remove-interface-on-link-down-firmwar.patch 2.4 KB
History Raw

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960 
  1. From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>
    2. 

  2. Date: Mon, 30 May 2016 06:40:54 +0200
    3. 

  3. Subject: [PATCH] brcmfmac: don't remove interface on link down firmware event
    4. 

  4. MIME-Version: 1.0
    5. 

  5. Content-Type: text/plain; charset=UTF-8
    6. 

  6. Content-Transfer-Encoding: 8bit
    7. 

  7. 

  8. There are two firmware events we handle similarly in brcmfmac:
    9. 

  9. BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view
    10. 

  10. is that the first one means BSS remains present in the firmware. Trying
    11. 

  11. to (re)create it (e.g. when adding new virtual interface) will result in
    12. 

  12. an error.
    13. 

  13. 

  14. Current code treats both events in a similar way. It removes Linux
    15. 

  15. interface for each of them. It works OK with e.g. BCM43602. Its firmware
    16. 

  16. generates both events for each interface. It means we get BRCMF_E_LINK
    17. 

  17. and remove interface. That is soon followed by BRCMF_E_IF which means
    18. 

  18. BSS was also removed in a firmware. The only downside of this is a
    19. 

  19. harmless error like:
    20. 

  20. [  208.643180] brcmfmac: brcmf_fweh_call_event_handler: no interface object
    21. 

  21. 

  22. Unfortunately BCM4366 firmware doesn't automatically remove BSS and so
    23. 

  23. it doesn't generate BRCMF_E_IF. In such case we incorrectly remove Linux
    24. 

  24. interface on BRCMF_E_LINK as BSS is still present in the firmware. It
    25. 

  25. results in an error when trying to re-create virtual interface, e.g.:
    26. 

  26. > iw phy phy1 interface add wlan1-1 type __ap
    27. 

  27. [ 3602.929199] brcmfmac: brcmf_ap_add_vif: timeout occurred
    28. 

  28. command failed: I/O error (-5)
    29. 

  29. 

  30. With this patch we don't remove Linux interface while firmware keeps
    31. 

  31. BSS. Thanks to this we keep a consistent states of host driver and
    32. 

  32. device firmware.
    33. 

  33. 

  34. Further improvement should be to mark BSS as disabled and remove
    35. 

  35. interface on BRCMF_E_LINK. Then we should add support for reusing
    36. 

  36. BSS-es.
    37. 

  37. 

  38. Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
    39. 

  39. Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    40. 

  40. ---
    41. 

  41. 

  42. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
    43. 

  43. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
    44. 

  44. @@ -5448,7 +5448,6 @@ brcmf_notify_connect_status_ap(struct br
    45. 

  45.  			       struct net_device *ndev,
    46. 

  46.  			       const struct brcmf_event_msg *e, void *data)
    47. 

  47.  {
    48. 

  48. -	struct brcmf_if *ifp = netdev_priv(ndev);
    49. 

  49.  	static int generation;
    50. 

  50.  	u32 event = e->event_code;
    51. 

  51.  	u32 reason = e->reason;
    52. 

  52. @@ -5459,8 +5458,6 @@ brcmf_notify_connect_status_ap(struct br
    53. 

  53.  	    ndev != cfg_to_ndev(cfg)) {
    54. 

  54.  		brcmf_dbg(CONN, "AP mode link down\n");
    55. 

  55.  		complete(&cfg->vif_disabled);
    56. 

  56. -		if (ifp->vif->mbss)
    57. 

  57. -			brcmf_remove_interface(ifp);
    58. 

  58.  		return 0;
    59. 

  59.  	}
    60. 

  60.  
    61.